lkml.org 
[lkml]   [2023]   [May]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] pinctrl:sunplus: Add check for kmalloc
Tue, May 23, 2023 at 06:11:28PM +0800, Wells Lu kirjoitti:
> Fix Smatch static checker warning:
> potential null dereference 'configs'. (kmalloc returns null)

...

> configs = kmalloc(sizeof(*configs), GFP_KERNEL);
> + if (!configs)

> + return -ENOMEM;

"Fixing" by adding a memory leak is not probably a good approach.

...

> configs = kmalloc(sizeof(*configs), GFP_KERNEL);
> + if (!configs)
> + return -ENOMEM;

Ditto.

...

It might be that I'm mistaken. In this case please add an explanation why in
the commit message.

--
With Best Regards,
Andy Shevchenko


\
 
 \ /
  Last update: 2023-05-23 18:44    [W:0.054 / U:1.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site