Messages in this thread | | | Date | Tue, 23 May 2023 16:32:44 +0100 | From | "Russell King (Oracle)" <> | Subject | Re: [PATCH net v3 3/4] net: phy: mscc: remove unnecessary phydev locking |
| |
On Tue, May 23, 2023 at 05:31:07PM +0200, David Epping wrote: > Holding the struct phy_device (phydev) lock is unnecessary when > accessing phydev->interface in the PHY driver .config_init method, > which is the only place that vsc85xx_rgmii_set_skews() is called from. > > The phy_modify_paged() function implements required MDIO bus level > locking, which can not be achieved by a phydev lock. > > Signed-off-by: David Epping <david.epping@missinglinkelectronics.com>
Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Thanks!
-- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
| |