Messages in this thread | | | Date | Tue, 23 May 2023 08:33:04 -0700 | From | Jakub Kicinski <> | Subject | Re: [PATCH] bitfield: suggest using bitwise OR when combining bitfields |
| |
On Tue, 23 May 2023 14:16:30 +0200 Peter Rosin wrote: > Logical OR fails to deliver the desired result. Most of the time. > > Fixes: 3e9b3112ec74 ("add basic register-field manipulation macros") > Fixes: e2192de59e45 ("bitfield: add FIELD_PREP_CONST()")
Fixes tags for comment changes are an overkill. The change looks good.
Who are you expecting to take this patch? Feel free to repost this CCing netdev@ so networking can take it, otherwise maybe Andrew will? Not sure..
| |