Messages in this thread | | | Date | Mon, 22 May 2023 22:55:54 -0700 | From | Christoph Hellwig <> | Subject | Re: [PATCH v2] md/raid5: Convert stripe_head's "dev" to flexible array member |
| |
On Mon, May 22, 2023 at 02:21:15PM -0700, Kees Cook wrote: > - } dev[1]; /* allocated with extra space depending of RAID geometry */ > + } dev[]; /* allocated with extra space depending of RAID geometry */
I still think this should be:
/* allocated depending of RAID geometry */
now or dropped entirely, as the extra only made sense when it always had that magic one.
The actual code changes looks good to me:
Reviewed-by: Christoph Hellwig <hch@lst.de>
| |