Messages in this thread | | | From | Linus Walleij <> | Date | Mon, 22 May 2023 09:32:17 +0200 | Subject | Re: [PATCH V7 4/8] pinctrl: qcom: Add IPQ5018 pinctrl driver |
| |
On Fri, May 19, 2023 at 2:55 PM Sricharan Ramabadhran <quic_srichara@quicinc.com> wrote:
> Add pinctrl definitions for the TLMM of IPQ5018. > > Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> > Co-developed-by: Nitheesh Sekar <quic_nsekar@quicinc.com> > Signed-off-by: Nitheesh Sekar <quic_nsekar@quicinc.com> > Co-developed-by: Varadarajan Narayanan <quic_varada@quicinc.com> > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> > Signed-off-by: Sricharan Ramabadhran <quic_srichara@quicinc.com> > --- > [v7] No change
This looks mostly fine, but I want you to consider Andy's remarks. With those addressed: Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Can this file and the bindings be applied independently of the rest of the patches? In that case I can apply v8 bindings+this patch to the pinctrl tree.
Yours, Linus Walleij
| |