Messages in this thread | | | Date | Mon, 22 May 2023 08:13:04 +0100 | From | Conor Dooley <> | Subject | Re: [PATCH v4 03/10] dt-bindings: serial: add documentation for Bouffalolab UART Driver |
| |
On Sun, May 21, 2023 at 05:13:38PM +0800, Jisheng Zhang wrote: > On Thu, May 18, 2023 at 10:00:50PM -0500, Samuel Holland wrote: > > On 5/18/23 10:22, Jisheng Zhang wrote:
> > This is not complete. There are separate APB and module (baud) clocks, > > as well as a peripheral reset line. If we are going to keep the binding > > stable, these need to be described up front. > > IIUC, the only requirement is to keep the driver compatible with both > new dts and old dts. clk tree and reset can be added latter. I have seen > sevral such examples from other SoCs' mainline progress.
It is generally preferred to add bindings in as complete a state as possible. The driver doesn't need to actually make use of all of the properties though, and can add the other bits as if/when they are required.
Cheers, Conor. [unhandled content-type:application/pgp-signature] | |