Messages in this thread | | | Date | Mon, 22 May 2023 08:11:43 +0100 | From | Lee Jones <> | Subject | Re: [PATCH 1/2] mfd: max5970: Rename driver and remove wildcard |
| |
On Thu, 18 May 2023, Naresh Solanki wrote:
> Hi Lee, > > On 18-05-2023 03:44 pm, Lee Jones wrote: > > On Thu, 27 Apr 2023, Naresh Solanki wrote: > > > > > The previous version of this driver included wildcards in file names > > > and descriptions. This patch renames the driver to only support MAX5970 > > > and MAX5978, which are the only chips that the driver actually supports. > > > > So multiple devices are supported: > > > > MAX5970 ... AND > > MAX5978 ... thus > > MAX597X ... does make sense, no? > > What are you trying to achieve? > Understood. It is important to note that there are indeed other unrelated > chips in addition to MAX5970 and MAX5978. Examples include MAX5971, which is > a Single-Port, 40W, IEEE 802.3af/at PSE Controller with Integrated MOSFET, > and MAX5974A, an Active-Clamped, Spread-Spectrum, Current-Mode PWM > Controller, among others. > > With this change, the intention is to be specific about the chips the driver > supports. Instead of using wildcards or a broad "MAX597X" designation, the > patch aims to exclusively support the MAX5970 and MAX5978 chips.
It's a tricky situation when engineers/marketing people name devices in a nonsensical manner. However, "max5970" just as misleading in this context as "max597x", thus the patch doesn't improve anything. It's more of a maneuver side-ways.
> > > Signed-off-by: Naresh Solanki <Naresh.Solanki@9elements.com> > > > --- > > > drivers/mfd/Kconfig | 4 ++-- > > > drivers/mfd/simple-mfd-i2c.c | 18 +++++++++--------- > > > include/linux/mfd/{max597x.h => max5970.h} | 16 ++++++++-------- > > > 3 files changed, 19 insertions(+), 19 deletions(-) > > > rename include/linux/mfd/{max597x.h => max5970.h} (92%)
-- Lee Jones [李琼斯]
| |