Messages in this thread | | | From | Azeem Shaikh <> | Date | Mon, 22 May 2023 12:18:45 -0400 | Subject | Re: [PATCH] dlm: Replace all non-returning strlcpy with strscpy |
| |
On Thu, May 11, 2023 at 12:26 PM Kees Cook <keescook@chromium.org> wrote: > > On Wed, May 10, 2023 at 10:12:37PM +0000, Azeem Shaikh wrote: > > strlcpy() reads the entire source buffer first. > > This read may exceed the destination size limit. > > This is both inefficient and can lead to linear read > > overflows if a source string is not NUL-terminated [1]. > > In an effort to remove strlcpy() completely [2], replace > > strlcpy() here with strscpy(). > > No return values were used, so direct replacement is safe. > > > > [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy > > [2] https://github.com/KSPP/linux/issues/89 > > > > Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com> > > Reviewed-by: Kees Cook <keescook@chromium.org> > > -- > Kees Cook
Friendly ping on this.
| |