Messages in this thread | | | From | Miquel Raynal <> | Subject | Re: [PATCH] mtd: spi-nor: Fix divide by zero for spi-nor-generic flashes | Date | Mon, 22 May 2023 17:58:35 +0200 |
| |
On Thu, 2023-05-18 at 08:54:40 UTC, Tudor Ambarus wrote: > We failed to initialize n_banks for spi-nor-generic flashes, which > caused a devide by zero when computing the bank_size. > > By default we consider that all chips have a single bank. Initialize > the default number of banks for spi-nor-generic flashes. Even if the > bug is fixed with this simple initialization, check the n_banks value > before dividing so that we make sure this kind of bug won't occur again > if some other struct instance is created uninitialized. > > Suggested-by: Todd Brandt <todd.e.brandt@linux.intel.com> > Reported-by: Todd Brandt <todd.e.brandt@linux.intel.com> > Closes: https://bugzilla.kernel.org/show_bug.cgi?id=217448 > Fixes: 9d6c5d64f028 ("mtd: spi-nor: Introduce the concept of bank") > Link: https://lore.kernel.org/all/20230516225108.29194-1-todd.e.brandt@intel.com/ > Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org> > Tested-by: Todd Brandt <todd.e.brandt@linux.intel.com> > Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/fixes, thanks.
Miquel
| |