Messages in this thread | | | From | Magnus Karlsson <> | Date | Mon, 22 May 2023 17:27:27 +0200 | Subject | Re: [Intel-wired-lan] [PATCH net-next 07/11] net: page_pool: add DMA-sync-for-CPU inline helpers |
| |
On Mon, 22 May 2023 at 15:50, Alexander Lobakin <aleksander.lobakin@intel.com> wrote: > > From: Jakub Kicinski <kuba@kernel.org> > Date: Fri, 19 May 2023 13:45:45 -0700 > > > On Fri, 19 May 2023 15:56:40 +0200 Alexander Lobakin wrote: > >> From: Jakub Kicinski <kuba@kernel.org> > >> Date: Thu, 18 May 2023 13:36:27 -0700 > > [...] > > > Ack, not saying that we need to split now, it's just about the naming > > (everyone's favorite topic). > > > > I think that it's a touch weird to name the header _drv.h and then > > include it in the core in multiple places (*cough* xdp_sock_drv.h). > > Hahaha, I also thought of it :>
Haha! Point taken. Will clear it up.
> > Also If someone needs to add another "heavy" static line for use by > > the core they will try to put it in page_pool.h rather than _drv.h... > > > > I'd rather split the includes by the basic language-level contents, > > first, then by the intended consumer, only if necessary. Language > > level sorting require less thinking :) > > > > But none of this is important, if you don't wanna to do it, just keep > > the new helpers in page_pool.h (let's not do another _drv.h). > > Ack, will just put there. It doesn't get included by the whole kernel > via skbuff.h anymore (in v2), so new inlines won't hurt. > > Thanks, > Olek > _______________________________________________ > Intel-wired-lan mailing list > Intel-wired-lan@osuosl.org > https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
| |