Messages in this thread | | | Date | Wed, 3 May 2023 01:18:38 +0200 | From | Andrew Lunn <> | Subject | Re: [PATCH v2 net 2/2] net: fec: restructuring the functions to avoid forward declarations |
| |
On Tue, May 02, 2023 at 05:08:18PM -0500, Shenwei Wang wrote: > The patch reorganizes functions related to XDP frame transmission, moving > them above the fec_enet_run_xdp implementation. This eliminates the need > for forward declarations of these functions.
I'm confused. Are these two patches in the wrong order?
The reason that i asked you to fix the forward declaration in net-next is that it makes your fix two patches. Sometimes that is not obvious to people back porting patches, and one gets lost, causing build problems. So it is better to have a single patch which is maybe not 100% best practice merged to stable, and then a cleanup patch merged to the head of development.
Andrew
| |