Messages in this thread | ![/](/images/icornerl.gif) | | Date | Tue, 2 May 2023 09:05:29 +0200 | From | Thomas Weißschuh <> | Subject | Re: [PATCH] tools/nolibc: remove LINUX_REBOOT_ constants |
| |
On 2023-05-02 08:59:27+0200, Willy Tarreau wrote:
<snip>
> > The following trivial fix on top of my patch would fix the problem: > > > > diff --git a/tools/include/nolibc/sys.h b/tools/include/nolibc/sys.h > > index 5d624dc63a42..9d27131c224e 100644 > > --- a/tools/include/nolibc/sys.h > > +++ b/tools/include/nolibc/sys.h > > @@ -21,6 +21,7 @@ > > #include <linux/auxvec.h> > > #include <linux/fcntl.h> // for O_* and AT_* > > #include <linux/stat.h> // for statx() > > +#include <linux/reboot.h> // for LINUX_REBOOT_* > > > > #include "arch.h" > > #include "errno.h" > > Indeed it works for me as well. > > > Want me to send a v2 or will you fix it up on your side? > > It depends. If for you it's a fix and needed for 6.4 (or maybe older), > then that one is needed with the "//" comment, and it will later > conflict with your previous cleanup patch that's already queued. If > you're fine with having it queued for 6.5 only however, then I'll just > edit your patch and add that above. I tend to think the second solution > is sufficient given that nobody complained till now ;-)
This is absolutely not urgent. 6.5 is fine.
Thomas
| ![\](/images/icornerr.gif) |