lkml.org 
[lkml]   [2023]   [May]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    Subject[PATCH v4 43/44] perf stat: Don't disable TopdownL1 metric on hybrid
    From
    Now that hybrid bugs are fixed sufficient to run TopdownL1 metrics,
    don't implicitly disable them for hybrid.

    Signed-off-by: Ian Rogers <irogers@google.com>
    ---
    tools/perf/builtin-stat.c | 7 +------
    1 file changed, 1 insertion(+), 6 deletions(-)

    diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
    index f4e572f9de6b..67dc69270ae4 100644
    --- a/tools/perf/builtin-stat.c
    +++ b/tools/perf/builtin-stat.c
    @@ -1900,12 +1900,7 @@ static int add_default_attributes(void)
    * Add TopdownL1 metrics if they exist. To minimize
    * multiplexing, don't request threshold computation.
    */
    - /*
    - * TODO: TopdownL1 is disabled on hybrid CPUs to avoid a crashes
    - * caused by exposing latent bugs. This is fixed properly in:
    - * https://lore.kernel.org/lkml/bff481ba-e60a-763f-0aa0-3ee53302c480@linux.intel.com/
    - */
    - if (metricgroup__has_metric(pmu, "TopdownL1") && !perf_pmu__has_hybrid()) {
    + if (metricgroup__has_metric(pmu, "TopdownL1")) {
    struct evlist *metric_evlist = evlist__new();
    struct evsel *metric_evsel;

    --
    2.40.1.495.gc816e09b53d-goog
    \
     
     \ /
      Last update: 2023-05-03 00:48    [W:4.266 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site