Messages in this thread | | | Date | Tue, 2 May 2023 16:46:17 +0200 | From | Simon Horman <> | Subject | Re: [PATCH 1/5] 9p: fix ignored return value in v9fs_dir_release |
| |
On Thu, Apr 27, 2023 at 08:23:34PM +0900, Dominique Martinet wrote: > retval from filemap_fdatawrite was immediately overwritten by the > following p9_fid_put: preserve any error in fdatawrite if there > was any first. > > This fixes the following scan-build warning: > fs/9p/vfs_dir.c:220:4: warning: Value stored to 'retval' is never read [deadcode.DeadStores] > retval = filemap_fdatawrite(inode->i_mapping); > ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Perhaps:
Fixes: 89c58cb395ec ("fs/9p: fix error reporting in v9fs_dir_release")
> Signed-off-by: Dominique Martinet <asmadeus@codewreck.org>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
| |