lkml.org 
[lkml]   [2023]   [May]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[RFC PATCH 1/3] cgroup: Drop unused function for cgroup_path
    Date
    There is no current user and there are alternative methods to obtain
    task's cgroup path.

    Signed-off-by: Michal Koutný <mkoutny@suse.com>
    ---
    kernel/cgroup/cgroup.c | 39 ---------------------------------------
    1 file changed, 39 deletions(-)

    diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c
    index 625d7483951c..55e5f0110e3b 100644
    --- a/kernel/cgroup/cgroup.c
    +++ b/kernel/cgroup/cgroup.c
    @@ -2378,45 +2378,6 @@ int cgroup_path_ns(struct cgroup *cgrp, char *buf, size_t buflen,
    }
    EXPORT_SYMBOL_GPL(cgroup_path_ns);

    -/**
    - * task_cgroup_path - cgroup path of a task in the first cgroup hierarchy
    - * @task: target task
    - * @buf: the buffer to write the path into
    - * @buflen: the length of the buffer
    - *
    - * Determine @task's cgroup on the first (the one with the lowest non-zero
    - * hierarchy_id) cgroup hierarchy and copy its path into @buf. This
    - * function grabs cgroup_mutex and shouldn't be used inside locks used by
    - * cgroup controller callbacks.
    - *
    - * Return value is the same as kernfs_path().
    - */
    -int task_cgroup_path(struct task_struct *task, char *buf, size_t buflen)
    -{
    - struct cgroup_root *root;
    - struct cgroup *cgrp;
    - int hierarchy_id = 1;
    - int ret;
    -
    - cgroup_lock();
    - spin_lock_irq(&css_set_lock);
    -
    - root = idr_get_next(&cgroup_hierarchy_idr, &hierarchy_id);
    -
    - if (root) {
    - cgrp = task_cgroup_from_root(task, root);
    - ret = cgroup_path_ns_locked(cgrp, buf, buflen, &init_cgroup_ns);
    - } else {
    - /* if no hierarchy exists, everyone is in "/" */
    - ret = strscpy(buf, "/", buflen);
    - }
    -
    - spin_unlock_irq(&css_set_lock);
    - cgroup_unlock();
    - return ret;
    -}
    -EXPORT_SYMBOL_GPL(task_cgroup_path);
    -
    /**
    * cgroup_attach_lock - Lock for ->attach()
    * @lock_threadgroup: whether to down_write cgroup_threadgroup_rwsem
    --
    2.40.1
    \
     
     \ /
      Last update: 2023-05-02 15:42    [W:2.711 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site