Messages in this thread | | | Date | Fri, 19 May 2023 20:13:44 +0100 | From | Conor Dooley <> | Subject | Re: [PATCH v3 2/3] dt-bindings: PCI: xilinx-xdma: Add YAML schemas for Xilinx XDMA PCIe Root Port Bridge |
| |
On Fri, May 19, 2023 at 04:29:00PM +0530, Thippeswamy Havalige wrote: > Add YAML dtschemas of Xilinx XDMA Soft IP PCIe Root Port Bridge > dt binding. > > Signed-off-by: Thippeswamy Havalige <thippeswamy.havalige@amd.com> > Signed-off-by: Bharat Kumar Gogada <bharat.kumar.gogada@amd.com>
Looks like you might've forgotten a Co-developed-by?
> diff --git a/Documentation/devicetree/bindings/pci/xlnx,xdma-host.yaml b/Documentation/devicetree/bindings/pci/xlnx,xdma-host.yaml
> +properties: > + compatible: > + const: xlnx,xdma-host-3.00
Perhaps not a question for you Thippeswamy, but is there a reason for PCI root ports not having any soc-specific compatibles? Rob (if you see this when you're back)?
> + interrupt-controller ;
Looks like you didn't see Michal's comment about the extra space. If you resubmit for some other reason, you should fix that in the process :)
Cheers, Conor. [unhandled content-type:application/pgp-signature] | |