Messages in this thread | | | Date | Fri, 19 May 2023 17:29:33 +0100 | From | Conor Dooley <> | Subject | Re: [PATCH] ASoC: dt-bindings: dialog,da7219: convert to dtschema |
| |
Hey David,
I think some wires got crossed here - what I meant was send 2 patches in a series, where one did the conversion and the other added the new property.
On Fri, May 19, 2023 at 09:23:21AM +0000, David Rau wrote: > Convert Dialog DA7219 bindings to DT schema format. > > Signed-off-by: David Rau <David.Rau.opensource@dm.renesas.com>
> + interrupt-names: > + oneOf: > + - items: > + - const: wakeup > + - items: > + - const: irq > + description: > + Name associated with interrupt line. > + Should be "wakeup" if interrupt is to be used to wake system, > + otherwise "irq" should be used.
Hmm, that is not quite what I meant. I was thinking that you could add itemised descriptions for what the individual behaviours are. But on reflection, how about: interrupt-names: description: Should be "wakeup" if interrupt is to be used to wake the system, otherwise "irq" should be used. enum: - wakeup - irq
> + > + wakeup-source: > + type: boolean > + description: > + Flag to indicate this device can wake system (suspend/resume). > + > + "#clock-cells": > + const: 1 > + > + clock-output-names: > + minItems: 2 > + maxItems: 2
I was thinking clock-output-names: - items: - const: WCLK - const: BCLK (assuming I didn't misunderstand the text binding!)
> + description: > + Name given for DAI word clock and bit clock outputs. > + > + clocks:
maxItems: 1
> + description: > + phandle and clock specifier for codec MCLK. > + > + clock-names: > + const: mclk
> + dlg,jack-det-rate: > + enum: ["32ms_64ms", "64ms_128ms", "128ms_256ms", "256ms_512ms"]
The "s here are not needed btw, the other enums in the tree described like this (that use strings) avoid the "s.
Thanks & apologies for the confusion, Conor.
> + description: > + Jack type detection latency (3/4 pole). > + $ref: /schemas/types.yaml#/definitions/string [unhandled content-type:application/pgp-signature] | |