Messages in this thread Patch in this message | | | Date | Fri, 19 May 2023 15:20:52 +0200 | From | Simon Horman <> | Subject | Re: Re: [PATCH net-next v3] octeontx2-pf: Add support for page pool |
| |
On Fri, May 19, 2023 at 10:21:44AM +0000, Ratheesh Kannoth wrote: > > > -----Original Message----- > > From: Simon Horman <simon.horman@corigine.com> > > Sent: Friday, May 19, 2023 3:33 PM > > To: Ratheesh Kannoth <rkannoth@marvell.com> > > Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Sunil Kovvuri > > Goutham <sgoutham@marvell.com>; davem@davemloft.net; > > edumazet@google.com; kuba@kernel.org; pabeni@redhat.com; > > linyunsheng@huawei.com; Subbaraya Sundeep Bhatta > > <sbhatta@marvell.com>; Geethasowjanya Akula <gakula@marvell.com>; > > Srujana Challa <schalla@marvell.com>; Hariprasad Kelam > > <hkelam@marvell.com> > > Subject: [EXT] Re: [PATCH net-next v3] octeontx2-pf: Add support for page > > pool > > > > External Email > > > > ---------------------------------------------------------------------- > > On Fri, May 19, 2023 at 12:43:52PM +0530, Ratheesh Kannoth wrote: > > > Page pool for each rx queue enhance rx side performance by reclaiming > > > buffers back to each queue specific pool. DMA mapping is done only for > > > first allocation of buffers. > > > As subsequent buffers allocation avoid DMA mapping, it results in > > > performance improvement. > > > > > > Image | Performance > > > ------------ | ------------ > > > Vannila | 3Mpps > > > | > > > with this | 42Mpps > > > change | > > > --------------------------- > > > > > > Signed-off-by: Ratheesh Kannoth <rkannoth@marvell.com> > > > > ... > > > > > @@ -1205,10 +1226,28 @@ void otx2_sq_free_sqbs(struct otx2_nic *pfvf) > > > } > > > } > > > > > > +void otx2_free_bufs(struct otx2_nic *pfvf, struct otx2_pool *pool, > > > + u64 iova, int size) > > > +{ > > > + u64 pa = otx2_iova_to_phys(pfvf->iommu_domain, iova); > > > + struct page *page = virt_to_head_page(phys_to_virt(pa)); > > > > nit: please arrange local variables in networking code in reverse xmas tree > > order - longest line to shortest. > Variable "pa" is used in second line. Are you suggesting to defer assignment later; and only declare variables here in reverse xmas tree style ?
Yes, that is my suggestion.
| |