Messages in this thread | | | Date | Fri, 19 May 2023 07:27:18 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH] perf: qcom_l2_pmu: Make l2_cache_pmu_probe_cluster() more robust |
| |
On Thu, May 18, 2023 at 10:18:08AM +0200, Christophe JAILLET wrote: > But it looks cleaner and could silence static checker warning.
Thanks Christophe,
Of course, you found found this with your Coccinelle script so technically it already silences a static checker warning... But I ran into two list related use after frees yesterday so I'm definitely going to create a Smatch warning which will trigger here as well.
I'm NOT going to add a if (if_list_is_devm()) exception because I feel like that encourages subtle code and because devm_ lifetimes are complicated.
regards, dan carpenter
| |