Messages in this thread | | | From | Song Liu <> | Date | Fri, 19 May 2023 15:01:42 -0700 | Subject | Re: [PATCH OLK-5.10 v3 2/4] md/raid10: fix overflow in safe_delay_store |
| |
On Mon, May 15, 2023 at 6:49 AM <linan666@huaweicloud.com> wrote: > > From: Li Nan <linan122@huawei.com> > > There is no input check when echo md/safe_mode_delay and overflow will > occur. There is risk of overflow in strict_strtoul_scaled(), too. Fix it > by using kstrtoul instead of parsing word one by one. > > Fixes: 72e02075a33f ("md: factor out parsing of fixed-point numbers") > Signed-off-by: Li Nan <linan122@huawei.com> > Reviewed-by: Yu Kuai <yukuai3@huawei.com> > --- > drivers/md/md.c | 76 +++++++++++++++++++++++++++++++------------------ > 1 file changed, 48 insertions(+), 28 deletions(-)
This patch adds more complexity, which I don't really think is necessary. Can we just check for overflow in safe_delay_store()?
Thanks, Song
| |