lkml.org 
[lkml]   [2023]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH - for 6.4] tpm: tpm_tis: Disable interrupts for AEON UPX-i11
    From
    On Wed May 17, 2023 at 3:29 PM EEST, Peter Ujfalusi wrote:
    > The interrupts initially works on the device but they will stop arriving
    > after about 200 interrupts.
    >
    > On system reboot/shutdown this will cause a long wait (120000 jiffies).
    >
    > The interrupts on this device got enabled by commit
    > e644b2f498d2 ("tpm, tpm_tis: Enable interrupt test")
    >
    > Prior to this point the interrupts were not enabled on this machine.
    >
    > Complements: e644b2f498d2 ("tpm, tpm_tis: Enable interrupt test")

    Complements -> Fixes

    > Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
    > ---
    > Hi,
    >
    > This patch applies on top of mainline since 6.4-rc1 takes about 2 minutes to
    > reboot on this machine, linux-next have
    > e7d3e5c4b1dd tpm/tpm_tis: Disable interrupts for more Lenovo devices
    >
    > I'm not sure if I shouold send this on top of next or mainline is fine, please
    > let me know the preferred way to get this to 6.4.
    >
    > Regards,
    > Peter
    >
    > drivers/char/tpm/tpm_tis.c | 7 +++++++
    > 1 file changed, 7 insertions(+)
    >
    > diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c
    > index 7af389806643..aad682c2ab21 100644
    > --- a/drivers/char/tpm/tpm_tis.c
    > +++ b/drivers/char/tpm/tpm_tis.c
    > @@ -122,6 +122,13 @@ static const struct dmi_system_id tpm_tis_dmi_table[] = {
    > DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad T490s"),
    > },
    > },
    > + {
    > + .callback = tpm_tis_disable_irq,
    > + .ident = "UPX-TGL",
    > + .matches = {
    > + DMI_MATCH(DMI_SYS_VENDOR, "AAEON"),
    > + },
    > + },
    > {}
    > };
    >
    > --
    > 2.40.1

    Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>

    BR, Jarkko

    \
     
     \ /
      Last update: 2023-05-18 20:39    [W:4.718 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site