Messages in this thread | | | Date | Thu, 18 May 2023 20:23:02 +0200 | From | Oleg Nesterov <> | Subject | Re: [RFC PATCH 1/8] signal: Dequeue SIGKILL even if SIGNAL_GROUP_EXIT/group_exec_task is set |
| |
On 05/18, Christian Brauner wrote: > > On Thu, May 18, 2023 at 08:08:10PM +0200, Oleg Nesterov wrote: > > On 05/18, Christian Brauner wrote: > > > > > > Yeah, but these are issues that exist with PF_IO_WORKER then too > > > > This was my thought too but I am starting to think I was wrong. > > > > Of course I don't understand the code in io_uring/ but it seems > > that it always breaks the IO loops if get_signal() returns SIGKILL. > > Yeah, it does and I think Mike has a point that vhost could be running > into an issue here that io_uring currently does avoid. But I don't think > we should rely on that.
So what do you propose?
Unless (quite possibly) I am confused again, unlike io_uring vhost can't tolerate signal_pending() == T in the cleanup-after-SIGKILL paths?
Oleg.
| |