lkml.org 
[lkml]   [2023]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH AUTOSEL 6.3 34/44] media: cros-ec-cec: Don't exit early in .remove() callback
On Mon, May 01, 2023 at 05:26:32PM +0200, Uwe Kleine-König wrote:
>Hello,
>
>On Sun, Apr 30, 2023 at 10:56:22PM -0400, Sasha Levin wrote:
>> From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>>
>> [ Upstream commit 0ff7aee24e47beb4306ce050824b54147f2fabfa ]
>>
>> Exiting early in remove without releasing all acquired resources yields
>> leaks. Note that e.g. memory allocated with devm_zalloc() is freed after
>> .remove() returns, even if the return code was negative.
>>
>> While blocking_notifier_chain_unregister() won't fail and so the
>> change is somewhat cosmetic, platform driver's .remove callbacks are
>> about to be converted to return void. To prepare that, keep the error
>> message but don't return early.
>>
>> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
>> Signed-off-by: Sasha Levin <sashal@kernel.org>
>
>While I'm positive this change doesn't break anything, it also doesn't
>fix anything and is only cosmetic (+ preparing a later change).
>
>Unless you need it as a dependency I'd say, don't backport it for
>stable.

Ack, dropped. Thanks!

--
Thanks,
Sasha

\
 
 \ /
  Last update: 2023-05-18 19:03    [W:0.224 / U:0.448 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site