Messages in this thread | | | Date | Thu, 18 May 2023 18:52:34 +0200 | Subject | Re: [PATCH 05/20] x86: head: add dummy prototype for mk_early_pgtbl_32 | From | Alexander Lobakin <> |
| |
From: Arnd Bergmann <arnd@kernel.org> Date: Tue, 16 May 2023 21:35:34 +0200
> From: Arnd Bergmann <arnd@arndb.de> > > 'make W=1' warns about a function without a prototype in the x86-32 head code: > > arch/x86/kernel/head32.c:72:13: error: no previous prototype for 'mk_early_pgtbl_32' [-Werror=missing-prototypes] > > This is called from assembler code, so it does not actually need a prototype. > I could not find an appropriate header for it, so just declare it in front > of the definition to shut up th warning.
^^ the :p
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
I'd say, for the whole series:
Reviewed-by: Alexander Lobakin <aleksander.lobakin@intel.com>
BUT apart from the Xen part, it's all black magic rituals to me :D
Thanks, Olek
| |