lkml.org 
[lkml]   [2023]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ALSA: emu10k1: set variables emu1010_routing_info and emu1010_pads_info storage-class-specifier to static
On Thu, 18 May 2023 15:58:51 +0200,
Oswald Buddenhagen wrote:
>
> On Thu, May 18, 2023 at 08:38:26AM -0400, Tom Rix wrote:
> > smatch reports
> ^^^^^^ is this the best word to use here?

Note that smatch is a name of a static analysis tool :)

> > sound/pci/emu10k1/emumixer.c:519:39: warning: symbol
> > 'emu1010_routing_info' was not declared. Should it be static?
> > sound/pci/emu10k1/emumixer.c:859:36: warning: symbol
> > 'emu1010_pads_info' was not declared. Should it be static?
> >
> > These variables are only used in their defining file, so it should be static
> ^^ they
> >
> > Signed-off-by: Tom Rix <trix@redhat.com>
> >
> Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
>
> (also amending one of the still pending patches. thanks!)

Applied the patch now, thanks.


Takashi

\
 
 \ /
  Last update: 2023-05-18 16:32    [W:0.042 / U:0.420 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site