Messages in this thread | | | From | Huacai Chen <> | Date | Thu, 18 May 2023 11:12:26 +0800 | Subject | Re: [PATCH] perf symbol: Add LoongArch case in get_plt_sizes() |
| |
On Thu, May 18, 2023 at 11:06 AM Leo Yan <leo.yan@linaro.org> wrote: > > On Thu, May 18, 2023 at 10:11:27AM +0800, Huacai Chen wrote: > > Queued, thanks. > > The patch is fine for me. > > Should not perf patches are to be merged via Arnaldo's tree? I think both are OK, if Arnaldo takes this patch, I will drop it.
Huacai > > Thanks, > Leo > > > On Tue, May 9, 2023 at 2:56 PM Tiezhu Yang <yangtiezhu@loongson.cn> wrote: > > > > > > We can see the following definitions in bfd/elfnn-loongarch.c: > > > > > > #define PLT_HEADER_INSNS 8 > > > #define PLT_HEADER_SIZE (PLT_HEADER_INSNS * 4) > > > > > > #define PLT_ENTRY_INSNS 4 > > > #define PLT_ENTRY_SIZE (PLT_ENTRY_INSNS * 4) > > > > > > so plt header size is 32 and plt entry size is 16 on LoongArch, > > > let us add LoongArch case in get_plt_sizes(). > > > > > > Link: https://sourceware.org/git/?p=binutils-gdb.git;a=blob;f=bfd/elfnn-loongarch.c > > > Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn> > > > --- > > > > > > This is based on 6.4-rc1 > > > > > > tools/perf/util/symbol-elf.c | 4 ++++ > > > 1 file changed, 4 insertions(+) > > > > > > diff --git a/tools/perf/util/symbol-elf.c b/tools/perf/util/symbol-elf.c > > > index b2ed9cc..5d409c2 100644 > > > --- a/tools/perf/util/symbol-elf.c > > > +++ b/tools/perf/util/symbol-elf.c > > > @@ -411,6 +411,10 @@ static bool get_plt_sizes(struct dso *dso, GElf_Ehdr *ehdr, GElf_Shdr *shdr_plt, > > > *plt_header_size = 32; > > > *plt_entry_size = 16; > > > return true; > > > + case EM_LOONGARCH: > > > + *plt_header_size = 32; > > > + *plt_entry_size = 16; > > > + return true; > > > case EM_SPARC: > > > *plt_header_size = 48; > > > *plt_entry_size = 12; > > > -- > > > 2.1.0 > > > > > >
| |