| From | Ard Biesheuvel <> | Date | Tue, 16 May 2023 19:50:54 +0200 | Subject | Re: [PATCH v2 08/20] x86: decompressor: Merge trampoline cleanup with switching code |
| |
On Mon, 15 May 2023 at 16:10, Kirill A. Shutemov <kirill@shutemov.name> wrote: > > On Mon, May 08, 2023 at 09:03:18AM +0200, Ard Biesheuvel wrote: > > @@ -215,4 +208,5 @@ void cleanup_trampoline(void *pgtable) > > ptrs_per_p4d = 512; > > } > > #endif > > + return; > > } > > Return is redundant here.
The return (or at least just a semicolon) is needed here because of the goto label right before the #ifdef block, as otherwise, the function would end with a label and the compiler does not like that.
> Otherwise: > > Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com> >
Thanks.
|