Messages in this thread | | | From | Jesper Dangaard Brouer <> | Date | Mon, 15 May 2023 17:07:19 +0200 | Subject | Re: [PATCH RESEND bpf-next 10/15] ice: Implement VLAN tag hint |
| |
On 15/05/2023 15.41, Larysa Zaremba wrote: >>> + *vlan_tag = ice_get_vlan_tag_from_rx_desc(xdp_ext->eop_desc); >> Should we also do the following: >> >> if (!*vlan_tag) >> return -ENODATA; >> >> ? > Oh, returning VLAN tag with zero value really made sense to me at the beginning, > but after playing with different kinds of packets, I think returning error makes > more sense. Will change. >
IIRC then VLAN tag zero is also a valid id, right?
--Jesper
| |