Messages in this thread | | | Date | Sun, 14 May 2023 22:21:38 +0200 | Subject | Re: [PATCH 0/4] x86-android-tablets: convert to using GPIO references | From | Hans de Goede <> |
| |
Hi Dmitry,
On 5/12/23 02:18, Dmitry Torokhov wrote: > Hi Hans, > > This series came about because now software nodes can be used to > describe GPIOs (via PROPERTY_ENTRY_GPIO() macros) and I would like to > eventually get rid of gpio_keys_platform_data structure. > > So while I was doing the conversions from GPIO_LOOKUP() tables for > gpio_keys devices I decided to convert the rest of them as well. Maybe > some time in the future we can drop support for GPIO_LOOKUP() and rely > on device properties exclusively. > > This is completely untested.
Thank you for your work on this. I have hw to test this.
But it seems that you have based this on an older tree, in 6.4-rc1 the x86-android-tablets code has been split over multiple files in their own subdir because it was becoming unyielding.
Can you please rebase this on top of:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=for-next
?
Regards,
Hans
> Dmitry Torokhov (4): > platform/x86: x86-android-tablets: convert Goodix devices to GPIO references > platform/x86: x86-android-tablets: convert int3496 devices to GPIO references > platform/x86: x86-android-tablets: convert wm1502 devices to GPIO references > platform/x86: x86-android-tablets: convert gpio_keys devices to GPIO references > > drivers/platform/x86/x86-android-tablets.c | 355 ++++++++++++--------- > 1 file changed, 201 insertions(+), 154 deletions(-) >
| |