Messages in this thread | | | Date | Sun, 14 May 2023 19:39:28 +0100 | From | Conor Dooley <> | Subject | Re: [PATCH v3 06/10] dt-bindings: riscv: Add bouffalolab bl808 board compatibles |
| |
On Mon, May 15, 2023 at 12:56:47AM +0800, Jisheng Zhang wrote:
> +title: Bouffalo Lab Technology SoC-based boards
I know you're only propagating an existing pattern, but the "SoC-based" looks rather odd!
> +properties: > + $nodename: > + const: '/' > + compatible: > + oneOf: > + - description: Carrier boards for the Sipeed M1s SoM > + items: > + - enum: > + - sipeed,m1s-dock
BTW, do you know of any other m1s compatible docks? I couldn't find any other ones via Google, so maybe it is just worth swapping the enum here for another const. Either is fine by me though. Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Thanks, Conor. [unhandled content-type:application/pgp-signature] | |