lkml.org 
[lkml]   [2023]   [May]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: Futexes & Folios
Date
On Sat, May 13 2023 at 17:16, Matthew Wilcox wrote:

> Here's a patch which converts the futex code from using pages to using
> folios. I do have some questions.
>
> - I assume we really do want to base the key on the page offset of the
> futex in the file. That is, it's not good enough to base the key
> on the folio's index because the folio can be split after setting up
> the key, and if it is we'd then fail to find the futex later.

Correct.

> - In hugetlbfs, it doesn't matter whether the pgoff is based on base
> pages or huge page size -- as long as it's consistent between
> invocations, everything will work

Yes.

The patch looks sane, but I need to have a look with brain more awake

Thanks,

tglx

\
 
 \ /
  Last update: 2023-05-13 21:58    [W:0.028 / U:0.924 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site