lkml.org 
[lkml]   [2023]   [May]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 05/10] dt-bindings: mfd: cirrus,cs42l43: Add initial DT binding
    From
    On 12/05/2023 18:18, Charles Keepax wrote:
    > On Fri, May 12, 2023 at 05:25:52PM +0200, Krzysztof Kozlowski wrote:
    >> On 12/05/2023 14:28, Charles Keepax wrote:
    >>> The CS42L43 is an audio CODEC with integrated MIPI SoundWire interface
    >>> (Version 1.2.1 compliant), I2C, SPI, and I2S/TDM interfaces designed
    >>> for portable applications. It provides a high dynamic range, stereo
    >>> DAC for headphone output, two integrated Class D amplifiers for
    >>
    >> ...
    >>
    >>> +
    >>> + interrupt-controller: true
    >>> +
    >>> + '#interrupt-cells':
    >>> + const: 2
    >>
    >> Hm, are you sure? Who is the consumer/user of this interrupt controller?
    >>
    >
    > Anyone who wants the device has GPIOs that can signal IRQs. Some
    > of the other IRQs could be more generally useful, such as some of
    > the jack detection ones.


    OK, makes sense, but it is a bit odd then to have:
    codec {
    which is GPIO and interrupt controller, but not pin controller
    pinctrl {
    pin controller, which is not GPIO and not interrupt controller
    }
    }
    Maybe all the GPIO/pin/related interrupt properties should be moved to
    pinctrl node?

    Best regards,
    Krzysztof

    \
     
     \ /
      Last update: 2023-05-13 20:09    [W:4.169 / U:0.988 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site