lkml.org 
[lkml]   [2023]   [May]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 12/24] media: ttusb-dec: fix memory leak in ttusb_dec_exit_dvb()
    Date
    From: Hyunwoo Kim <imv4bel@gmail.com>

    Since dvb_frontend_detach() is not called in ttusb_dec_exit_dvb(),
    which is called when the device is disconnected, dvb_frontend_free()
    is not finally called.

    This causes a memory leak just by repeatedly plugging and
    unplugging the device.

    Fix this issue by adding dvb_frontend_detach() to ttusb_dec_exit_dvb().

    Link: https://lore.kernel.org/linux-media/20221117045925.14297-5-imv4bel@gmail.com
    Signed-off-by: Hyunwoo Kim <imv4bel@gmail.com>
    Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
    ---
    drivers/media/usb/ttusb-dec/ttusb_dec.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/drivers/media/usb/ttusb-dec/ttusb_dec.c b/drivers/media/usb/ttusb-dec/ttusb_dec.c
    index 38822cedd93a..c4474d4c44e2 100644
    --- a/drivers/media/usb/ttusb-dec/ttusb_dec.c
    +++ b/drivers/media/usb/ttusb-dec/ttusb_dec.c
    @@ -1544,8 +1544,7 @@ static void ttusb_dec_exit_dvb(struct ttusb_dec *dec)
    dvb_dmx_release(&dec->demux);
    if (dec->fe) {
    dvb_unregister_frontend(dec->fe);
    - if (dec->fe->ops.release)
    - dec->fe->ops.release(dec->fe);
    + dvb_frontend_detach(dec->fe);
    }
    dvb_unregister_adapter(&dec->adapter);
    }
    --
    2.40.1
    \
     
     \ /
      Last update: 2023-05-13 19:58    [W:2.770 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site