Messages in this thread | | | Date | Sat, 13 May 2023 16:57:19 +0200 | From | Artur Rojek <> | Subject | Re: [PATCH 1/2] sh: dma: fix `dmaor_read_reg`/`dmaor_write_reg` macros |
| |
On 2023-05-13 16:45, John Paul Adrian Glaubitz wrote: > Hi Artur! > > On Sat, 2023-05-13 at 13:41 +0200, Artur Rojek wrote: >> Yikes! >> If this series hasn't been merged yet, perhaps we could fix this issue >> in v2. I have something like this in mind (untested): >> (...) >> Otherwise, I'll send it in separately. Of course we'll also need to >> fix >> `SH_DMAC_BASE1` so that it's set only for SoCs that feature two DMAC >> modules... > > No worries, nothing has been merged yet. For one, the merge windows for > 6.4 > has been closed and I also haven't merged your patches into my tree > yet. Please > take your time to spin up a v2 of your patch set and test them > properly.
Great!
> > Maybe you're also interested in the clean-up that Geert suggested in > this > thread (ordering of the CPU subtypes and capitalization issues)?
Sure, why not - the more clean-up we do, the better :)
> > Also, can you write "processor manual" instead of "PM" in the other > patch > as well as don't use backticks for the macro names? In fact, I would > suggest > retitling the subject to: > > sh: dma: Fix dmaor_read_reg() and dmaor_write_reg() macros >
Of course. On a side note, it was supposed to be "programming manual", however I now see that Renesas named that document as "hardware manual", so that's what I'll put into the commit description, if you don't mind.
cheers, Artur
> Oh, and I will retest your v2 patches before merging them, of course > ;-). > > Thanks, > Adrian
| |