Messages in this thread | | | Date | Fri, 12 May 2023 18:58:08 +0200 | Subject | Re: [PATCH v3 03/10] arm64: dts: qcom: qdu1000: Add properties to qfprom for multi channel DDR | From | Krzysztof Kozlowski <> |
| |
On 12/05/2023 14:21, Komal Bajaj wrote: > Add properties to the qfprom node for multi channel DDR. > > Signed-off-by: Komal Bajaj <quic_kbajaj@quicinc.com>
DTS goes to the end of patchset. Better - to separate patchset with links to bindings.
Subject: drop redundant pieces, it's too long without actual need. "properties to" can be skipped.
> --- > arch/arm64/boot/dts/qcom/qdu1000.dtsi | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/qdu1000.dtsi b/arch/arm64/boot/dts/qcom/qdu1000.dtsi > index 734438113bba..418644f396bc 100644 > --- a/arch/arm64/boot/dts/qcom/qdu1000.dtsi > +++ b/arch/arm64/boot/dts/qcom/qdu1000.dtsi > @@ -1333,6 +1333,18 @@ > interrupts = <GIC_SPI 266 IRQ_TYPE_LEVEL_HIGH>; > multi-ch-bit-off = <24 2>; > }; > + > + qfprom: efuse@221c8000 { > + compatible = "qcom,qdu1000-qfprom", "qcom,qfprom"; > + reg = <0 0x221c8000 0 0x1000>; > + #address-cells = <1>; > + #size-cells = <1>; > + > + multi_chan_ddr: multi_chan_ddr@12b {
No underscores in node names.
Best regards, Krzysztof
| |