Messages in this thread | | | Date | Fri, 12 May 2023 14:26:33 +0530 | Subject | Re: [PATCH v7 2/4] pinctrl: qcom: Remove the msm_function struct | From | Rohit Agarwal <> |
| |
On 5/11/2023 10:03 PM, Bjorn Andersson wrote: > On Wed, May 10, 2023 at 08:30:23PM +0530, Rohit Agarwal wrote: >> Remove the msm_function struct to reuse the generic pinfunction >> struct. Also, define a generic PINFUNCTION macro that can be used across >> qcom target specific pinctrl files to avoid code repetition. >> > Looks nice! No need to carry our own structs for things that has made it > into the framework. > > Reviewed-by: Bjorn Andersson <andersson@kernel.org> > > But, ipq9574.c has made it into linux-next now, so this breaks the build > of that driver. So please update this patch. And please send the two > refactoring patches on their own, followed by the SDX75 based on that, > so we can get those merged quickly, before any other impediments are > introduced. Sure, Will the refactoring patches independently rebased on linux-next.
Thanks, Rohit. > > Regards, > Bjorn
| |