Messages in this thread | | | Subject | Re: [PATCH -next 3/6] blk-wbt: don't enable wbt for bio based device | From | Yu Kuai <> | Date | Fri, 12 May 2023 15:06:07 +0800 |
| |
Hi,
在 2023/05/11 23:21, Christoph Hellwig 写道: > On Thu, May 11, 2023 at 09:45:06AM +0800, Yu Kuai wrote: >> From: Yu Kuai <yukuai3@huawei.com> >> >> Because rq_qos only make sense for rq based device. Instead of fail >> from sysfs configuration, make wbt sysfs dentry invisible directly. > > This looks ok, bt I would be better to just have a separate attr > group just for blk-mq based devices? >
Sounds good, I'll add a new attr_group that is only visible for rq based device, I think following attr can be moved to this new group:
nr_requests, rq_affinity, scheduler, wbt_lat_usec
Thanks, Kuai
| |