Messages in this thread | | | Date | Thu, 11 May 2023 08:54:53 -0700 | From | Stephen Hemminger <> | Subject | Re: [PATCH] ipvlan: Remove NULL check before dev_{put, hold} |
| |
On Thu, 11 May 2023 15:21:19 +0800 Yang Li <yang.lee@linux.alibaba.com> wrote:
> The call netdev_{put, hold} of dev_{put, hold} will check NULL, > so there is no need to check before using dev_{put, hold}, > remove it to silence the warning: > > ./drivers/net/ipvlan/ipvlan_core.c:559:3-11: WARNING: NULL check before dev_{put, hold} functions is not needed. > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4930 > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Maybe add new coccinelle script for this? scripts/free/dev_hold.cocci?
| |