Messages in this thread | | | Date | Thu, 11 May 2023 16:11:46 +0200 | From | Andrew Lunn <> | Subject | Re: [PATCH net-next v3 3/3] phy: mscc: Add support for VSC8531_02 |
| |
On Thu, May 11, 2023 at 05:38:08PM +0530, Harini Katakam wrote: > Add support for VSC8531_02 (Rev 2) device. Use exact PHY ID match. > > Signed-off-by: Harini Katakam <harini.katakam@amd.com> > --- > v3 - Patch split > > drivers/net/phy/mscc/mscc.h | 1 + > drivers/net/phy/mscc/mscc_main.c | 26 ++++++++++++++++++++++++-- > 2 files changed, 25 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/phy/mscc/mscc.h b/drivers/net/phy/mscc/mscc.h > index ab6c0b7c2136..6a0521ff61d2 100644 > --- a/drivers/net/phy/mscc/mscc.h > +++ b/drivers/net/phy/mscc/mscc.h > @@ -281,6 +281,7 @@ enum rgmii_clock_delay { > #define PHY_ID_VSC8514 0x00070670 > #define PHY_ID_VSC8530 0x00070560 > #define PHY_ID_VSC8531 0x00070570 > +#define PHY_ID_VSC8531_02 0x00070572
Does PHY_ID_VSC8531_01 exist? The current code would support that, where as now i don't think any entry will match.
Andrew
| |