Messages in this thread | | | Date | Thu, 11 May 2023 12:10:11 +0200 | From | Simon Horman <> | Subject | Re: [PATCH net-next v2 1/3] net: phy: Allow drivers to always call into ->suspend() |
| |
On Tue, May 09, 2023 at 03:34:01PM -0700, Florian Fainelli wrote: > A few PHY drivers are currently attempting to not suspend the PHY when > Wake-on-LAN is enabled, however that code is not currently executing at > all due to an early check in phy_suspend(). > > This prevents PHY drivers from making an appropriate decisions and put > the hardware into a low power state if desired. > > In order to allow the PHY drivers to opt into getting their ->suspend > routine to be called, add a PHY_ALWAYS_CALL_SUSPEND bit which can be > set. A boolean that tracks whether the PHY or the attached MAC has > Wake-on-LAN enabled is also provided for convenience. > > If phydev::wol_enabled then the PHY shall not prevent its own > Wake-on-LAN detection logic from working and shall not prevent the > Ethernet MAC from receiving packets for matching. > > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
| |