Messages in this thread | | | Date | Thu, 11 May 2023 11:26:19 +0200 | Subject | Re: [PATCH v2 1/2] dt-bindings: cdns,usb3: Add clock and reset | From | Krzysztof Kozlowski <> |
| |
On 10/05/2023 15:28, Minda Chen wrote: > To support generic clock and reset init in Cadence USBSS > controller, add clock and reset dts configuration. > > Signed-off-by: Minda Chen <minda.chen@starfivetech.com> > --- > .../devicetree/bindings/usb/cdns,usb3.yaml | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/Documentation/devicetree/bindings/usb/cdns,usb3.yaml b/Documentation/devicetree/bindings/usb/cdns,usb3.yaml > index cae46c4982ad..623c6b34dee3 100644 > --- a/Documentation/devicetree/bindings/usb/cdns,usb3.yaml > +++ b/Documentation/devicetree/bindings/usb/cdns,usb3.yaml > @@ -42,6 +42,18 @@ properties: > - const: otg > - const: wakeup > > + clocks: > + minItems: 1 > + maxItems: 8 > + description: > + USB controller clocks.
You need to list the items. And why is it variable? Your clock choice in the example is poor, I doubt it is real.
> + > + resets: > + minItems: 1 > + maxItems: 8 > + description: > + USB controller generic resets.
Here as well.
You had one clock last time, thus the review was - drop the names. Now you changed it to 8 clocks... I don't understand.
Best regards, Krzysztof
| |