Messages in this thread | | | Date | Thu, 11 May 2023 18:06:08 -0700 | From | Jakub Kicinski <> | Subject | Re: [PATCH v2 net-next] net: ethernet: mtk_eth_soc: log clock enable errors |
| |
On Wed, 10 May 2023 20:13:50 +0200 Lorenz Brun wrote: > for (clk = 0; clk < MTK_CLK_MAX ; clk++) { > ret = clk_prepare_enable(eth->clks[clk]); > - if (ret) > + if (ret) { > + dev_err(eth->dev, "enabling clock %s failed with error %d\n", > + mtk_clks_source_name[clk], ret); > goto err_disable_clks; > + }
dev_err_probe() would be even better, I think? -- pw-bot: cr
| |