lkml.org 
[lkml]   [2023]   [May]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 net-next] net: ethernet: mtk_eth_soc: log clock enable errors
On Wed, 10 May 2023 20:13:50 +0200 Lorenz Brun wrote:
> for (clk = 0; clk < MTK_CLK_MAX ; clk++) {
> ret = clk_prepare_enable(eth->clks[clk]);
> - if (ret)
> + if (ret) {
> + dev_err(eth->dev, "enabling clock %s failed with error %d\n",
> + mtk_clks_source_name[clk], ret);
> goto err_disable_clks;
> + }

dev_err_probe() would be even better, I think?
--
pw-bot: cr

\
 
 \ /
  Last update: 2023-05-12 03:07    [W:0.026 / U:0.272 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site