Messages in this thread | | | From | "Zhuo, Qiuxu" <> | Subject | RE: [PATCH rcu 3/6] rcu/rcuscale: Move rcu_scale_*() after kfree_scale_cleanup() | Date | Thu, 11 May 2023 07:01:59 +0000 |
| |
> From: Joel Fernandes <joel@joelfernandes.org> > Sent: Thursday, May 11, 2023 1:23 PM > To: Paul E. McKenney <paulmck@kernel.org> > Cc: rcu@vger.kernel.org; linux-kernel@vger.kernel.org; kernel- > team@meta.com; rostedt@goodmis.org; Zhuo, Qiuxu > <qiuxu.zhuo@intel.com> > Subject: Re: [PATCH rcu 3/6] rcu/rcuscale: Move rcu_scale_*() after > kfree_scale_cleanup() > > On Wed, May 10, 2023 at 10:12 AM Paul E. McKenney <paulmck@kernel.org> > wrote: > > > > From: Qiuxu Zhuo <qiuxu.zhuo@intel.com> > > > > This code-movement-only commit moves the rcu_scale_cleanup() and > > rcu_scale_shutdown() functions to follow kfree_scale_cleanup(). > > This is code movement is in preparation for a bug-fix patch that > > invokes > > kfree_scale_cleanup() from rcu_scale_cleanup(). > > > > Signed-off-by: Qiuxu Zhuo <qiuxu.zhuo@intel.com> > > Signed-off-by: Paul E. McKenney <paulmck@kernel.org> > > --- > > kernel/rcu/rcuscale.c | 194 > > +++++++++++++++++++++--------------------- > > 1 file changed, 97 insertions(+), 97 deletions(-) > > I wish diff was better at showing what really changed. The meld tool can help > but its gui... > > Should I run meld later (I'm out at a conference so no access to meld-capable > machines) or are we sufficiently confident that the lines were moved as-is ? :) >
Thank you, Joel for this concern. Good to know the meld diff GUI tool. I just run the command below and confirmed that the lines were moved as-is: rcu_scale_{cleanup,shutdown}() follows kfree_scale_cleanup(). You may double check it ;-).
meld --diff ./rcuscale.c.before ./rcuscale.c.after
-Qiuxu
> - Joel
| |