Messages in this thread | | | Date | Thu, 11 May 2023 23:29:20 +0100 | From | Conor Dooley <> | Subject | Re: [PATCH net-next v2 1/2] dt-bindings: net: cdns,macb: Add rx-watermark property |
| |
On Thu, May 11, 2023 at 08:25:15AM +0100, Conor Dooley wrote: > On Thu, May 11, 2023 at 01:12:13AM -0600, Pranavi Somisetty wrote: > > watermark value is the minimum amount of packet data > > required to activate the forwarding process. The watermark > > implementation and maximum size is dependent on the device > > where Cadence MACB/GEM is used. > > > > Signed-off-by: Pranavi Somisetty <pranavi.somisetty@amd.com> > > Please send dt-binding patches to the dt-binding maintainers and list. > get_maintainer.pl should have told you to do so & without having done > so, the bindings will not get tested :/
The automation we run for the linux-riscv did actually run against this though, and even dtbs_check complains about this binding:
Documentation/devicetree/bindings/net/cdns,macb.yaml: properties:rx-watermark:maxItems: False schema does not allow 1 hint: Scalar properties should not have array keywords from schema $id: http://devicetree.org/meta-schemas/keywords.yaml#
Please test your bindings :/
Cheers, Conor. [unhandled content-type:application/pgp-signature] | |