Messages in this thread | | | Date | Thu, 11 May 2023 23:00:02 +0300 (EEST) | From | Ilpo Järvinen <> | Subject | Re: [PATCH 14/17] r8169: Use pcie_lnkctl_clear_and_set() for changing LNKCTL |
| |
On Thu, 11 May 2023, Heiner Kallweit wrote:
> On 11.05.2023 15:14, Ilpo Järvinen wrote: > > Don't assume that only the driver would be accessing LNKCTL. ASPM > > policy changes can trigger write to LNKCTL outside of driver's control. > > > > Use pcie_lnkctl_clear_and_set() which does proper locking to avoid > > losing concurrent updates to the register value. > > > > Wouldn't it be more appropriate to add proper locking to the > underlying pcie_capability_clear_and_set_word()?
As per discussion for the other patch, that's where this series is now aiming to in v2.
-- i.
| |