Messages in this thread | | | Subject | Re: [PATCH v1] usb: xhci: plat: remove error log for failure to get usb-phy | From | Klaus Kudielka <> | Date | Wed, 10 May 2023 19:39:41 +0200 |
| |
On Wed, 2023-05-10 at 15:51 +0800, Stanley Chang wrote: > Remove this log to avoid non-error conditions. > If CONFIG_USB_PHY is disabled, the following error message appears: > [ 0.231609] xhci-hcd f10f0000.usb3: xhci_plat_probe get usb3phy fail (ret=-6) > [ 0.239716] xhci-hcd f10f8000.usb3: xhci_plat_probe get usb3phy fail (ret=-6) > In this case, devm_usb_get_phy_by_phandle is declared static inline > and returns -ENXIO. > > It is easy to pinpoint the failure to get the usb-phy using the debug > log in drivers/usb/phy/phy.c. Therefore, it can be removed. > > Signed-off-by: Stanley Chang <stanley_chang@realtek.com>
Thanks, the false positives are now gone for those without CONFIG_USB_PHY.
Tested-by: Klaus Kudielka <klaus.kudielka@gmail.com>
| |