lkml.org 
[lkml]   [2023]   [May]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] fs/coredump: open coredump file in O_WRONLY instead of O_RDWR
From
Gently ping.

Is there any interest?

On 20.04.23 15:04, Vladimir Sementsov-Ogievskiy wrote:
> This makes it possible to make stricter apparmor profile and don't
> allow the program to read any coredump in the system.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
> ---
> fs/coredump.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/coredump.c b/fs/coredump.c
> index 5df1e6e1eb2b..8f263a389175 100644
> --- a/fs/coredump.c
> +++ b/fs/coredump.c
> @@ -646,7 +646,7 @@ void do_coredump(const kernel_siginfo_t *siginfo)
> } else {
> struct mnt_idmap *idmap;
> struct inode *inode;
> - int open_flags = O_CREAT | O_RDWR | O_NOFOLLOW |
> + int open_flags = O_CREAT | O_WRONLY | O_NOFOLLOW |
> O_LARGEFILE | O_EXCL;
>
> if (cprm.limit < binfmt->min_coredump)

--
Best regards,
Vladimir

\
 
 \ /
  Last update: 2023-05-10 17:19    [W:0.454 / U:1.828 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site