Messages in this thread | | | Date | Wed, 10 May 2023 07:17:43 -0700 | Subject | Re: [PATCH net] net: bcmgenet: Restore phy_stop() depending upon suspend/close | From | Florian Fainelli <> |
| |
On 5/9/2023 3:59 PM, Florian Fainelli wrote: > Removing the phy_stop() from bcmgenet_netif_stop() ended up causing > warnings from the PHY library that phy_start() is called from the > RUNNING state since we are no longer stopping the PHY state machine. > > Restore the call to phy_stop() but make it conditional on being called > fro the close or suspend path. > > Fixes: 93e0401e0fc0 ("net: bcmgenet: Remove phy_stop() from bcmgenet_netif_stop()") > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Please do not apply this just yet, I need to run some additional tests, thanks! -- Florian
| |