Messages in this thread | | | Subject | Re: [PATCH 1/2] ASoC: dt-bindings: Add adi,ssm3515 amp schema | From | Martin Povišer <> | Date | Wed, 10 May 2023 10:15:55 +0200 |
| |
> On 10. 5. 2023, at 9:51, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 09/05/2023 18:38, Martin Povišer wrote: >> Add a DT schema for the SSM3515 amp by Analog Devices. It's a simple >> mono amplifier with digital input. >> >> Signed-off-by: Martin Povišer <povik+lin@cutebit.org> > > >> + reg: >> + maxItems: 1 >> + >> + adi,ana-gain: >> + $ref: /schemas/types.yaml#/definitions/uint32 >> + enum: [0, 1, 2, 3] >> + description: | >> + The value to be set in the ANA_GAIN register field on the codec. This determines >> + the full voltage span of the codec's analog output. >> + >> + To quote the datasheet on the available options: >> + >> + 00: 8.4 V Full-Scale Gain Mapping >> + 01: 12.6 V Full-Scale Gain Mapping >> + 10: 14 V Full-Scale Gain Mapping >> + 11: 15 V Full-Scale Gain Mapping >> + >> + '#sound-dai-cells': >> + const: 0 >> + >> +required: >> + - compatible >> + - reg >> + - adi,ana-gain >> + >> +additionalProperties: true > > uinevaluatedProperties: false instead, so users can have name-prefix.
I actually tweaked this to have the example passing, which has sound-name-prefix, which I guess is what you have in mind. Not that I exactly understand what these options do (both additionalProperties and unevaluatedProperties), the schema docs didn’t enlighten me right away when I looked into it.
If 'unevaluatedProperties: false' is the way to go here, I will change it.
Kind regards, Martin
> Best regards, > Krzysztof
| |