Messages in this thread | | | Subject | Re: [PATCH 1/4] perf trace-event-info: Add tracepoint_id_to_name() helper | From | Yang Jihong <> | Date | Wed, 10 May 2023 16:09:37 +0800 |
| |
Hello,
On 2023/5/10 15:48, Adrian Hunter wrote: > On 19/04/23 15:29, Yang Jihong wrote: >> Add tracepoint_id_to_name() helper to search for the trace events directory >> by given event id and return the corresponding tracepoint. >> >> Signed-off-by: Yang Jihong <yangjihong1@huawei.com> >> --- >> tools/perf/util/trace-event-info.c | 13 +++++++++++++ >> tools/perf/util/trace-event.h | 6 ++++++ >> 2 files changed, 19 insertions(+) >> >> diff --git a/tools/perf/util/trace-event-info.c b/tools/perf/util/trace-event-info.c >> index c24b3a15e319..79907caaf0ca 100644 >> --- a/tools/perf/util/trace-event-info.c >> +++ b/tools/perf/util/trace-event-info.c >> @@ -466,6 +466,19 @@ static struct tracepoint_path *tracepoint_id_to_path(u64 config) >> return NULL; >> } >> >> +char *tracepoint_id_to_name(u64 config) >> +{ >> + char buf[MAX_EVENT_LENGTH]; >> + struct tracepoint_path *path = NULL; > > Initializer should be tracepoint_id_to_path(config) i.e. > OK, will fix in next version.
> struct tracepoint_path *path = tracepoint_id_to_path(config); > >> + >> + path = tracepoint_id_to_path(config); >> + if (path == NULL) >> + return NULL; >> + >> + snprintf(buf, sizeof(buf), "%s:%s", path->system, path->name); > > asprintf() can be used then buf and strdup() are not needed. > OK, will fix in next version.
Thanks for correcting.
Thanks, Yang
| |